Conversation
kshyatt
force-pushed
the
ksh/amd
branch
2 times, most recently
from
6f7f6e1 to
01e3d88
Compare
lkdvos
reviewed
Jul 1, 2026
lkdvos
reviewed
Jul 2, 2026
lkdvos
left a comment
lkdvos
left a comment
Member
There was a problem hiding this comment.
left a small nitpick, otherwise happy to merge
| using TensorKit: ℙ | ||
| using Adapt, AMDGPU | ||
|
|
||
| @testset "CuMPS ($(sectortype(D)), $elt)" for (D, d, elt) in |
Member
There was a problem hiding this comment.
Suggested change
| @testset "CuMPS ($(sectortype(D)), $elt)" for (D, d, elt) in | |
| @testset "ROCMPS ($(sectortype(D)), $elt)" for (D, d, elt) in |
There's still a few of these left below as well, might be worth checking 😉
Member
Author
|
This won't be mergeable until we tag a new version of TensorKit because it needs the generic GPUArrays extension for a few things. |
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also realized the CUDA states tests were not running 😳